Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 🧪 added tests for .process_script() #476

Open
wants to merge 18 commits into
base: 4.x
Choose a base branch
from
Open

test: 🧪 added tests for .process_script() #476

wants to merge 18 commits into from

Conversation

KANAjetzt
Copy link
Member

@KANAjetzt KANAjetzt commented Nov 28, 2024 •
edited
Loading

This adds 3 test scripts (test_script_A / B / C.gd) with their expected results (test_script_A / B/ C_processed.gd) to validate the functionality of _ModLoaderModHookPreProcessor.process_script().

Note

The class_name in the _processed.gd scripts must be commented out to avoid the "hiding global class" error.
Test run is broken until #495 is merged or func please_stop is removed from test script C.

TODO

Dev Notes

  • add this to the test script
format_date(day: int, \
month: int, year: int, special_thing := "\n\t\"\
")
  • I think this covers it quiet well already:
func why_would_you(put: int, \
	backslashes := "\\", in_here := "?!\n"
	):
	pass

@KANAjetzt KANAjetzt added this to the 4.x - 7.0.0 milestone Nov 28, 2024
@KANAjetzt KANAjetzt self-assigned this Nov 28, 2024
@KANAjetzt KANAjetzt force-pushed the test_process_script branch 3 times, most recently from bb2cb2c to 9289597 Compare December 25, 2024 10:04
@KANAjetzt KANAjetzt mentioned this pull request Dec 25, 2024
Open
@KANAjetzt KANAjetzt marked this pull request as ready for review December 25, 2024 11:29
@KANAjetzt KANAjetzt requested a review from Qubus0 December 25, 2024 11:36
@KANAjetzt KANAjetzt force-pushed the test_process_script branch from c556201 to f73e930 Compare January 12, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubus0 Qubus0 Awaiting requested review from Qubus0

At least 1 approving review is required to merge this pull request.

Assignees

@KANAjetzt KANAjetzt

Labels
4.x test
Projects
Mod Hooks
Status: In review
Milestone
4.x - 7.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@KANAjetzt